Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20: Do not send emails that a reviewer has added a comment #19

Closed
wants to merge 3 commits into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Jul 1, 2019

Hi all,

Please review the following change that stops adding PR comments when a review is updated, if the host supports attaching comments directly to reviews (such as GitHub, but not GitLab CE).

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@openjdk openjdk bot added cli bots rfr labels Jul 1, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

mlbridge bot commented Jul 1, 2019

Webrevs

@edvbld
edvbld approved these changes Jul 1, 2019
Copy link
Member

edvbld left a comment

Awesome, thanks for fixing this 👏

@openjdk openjdk bot removed the rfr label Jul 1, 2019
@openjdk
Copy link

openjdk bot commented Jul 1, 2019

This PR has been reviewed by Erik Helin (ehelin - Reviewer) - changes are approved.

@openjdk
Copy link

openjdk bot commented Jul 1, 2019

@rwestberg This change can now be integrated. The commit message will be:

20: Do not send emails that a reviewer has added a comment

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jul 1, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Jul 1, 2019

/integrate

@openjdk openjdk bot closed this Jul 1, 2019
@openjdk
Copy link

openjdk bot commented Jul 1, 2019

@rwestberg Pushed as commit 2a1e24b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.