Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
5: Remove pipeline support from process #2
Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
Hi jeyvison, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing
Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review).
Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question..
All tests pass when I run them in your branch, what kind of problem did you see?
rwestberg left a comment
Overall this looks good, but it would be nice if the now-unnecessary lists could be removed as well, for example:
could just be a
@jeyvison This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 5 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge
As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg, @edvbld) but any other Committer may sponsor as well.