Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean and images targets to Makefile #211

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Oct 18, 2019

Hi,

this patch adds two new "wrapper" targets images and clean for the Makefile.

Thanks,
Erik

Testing

  • make images works
  • make clean works

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Oct 18, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

@edvbld
Copy link
Member Author

edvbld commented Oct 18, 2019

/integrate

@openjdk openjdk bot removed the rfr label Oct 18, 2019
@openjdk
Copy link

openjdk bot commented Oct 18, 2019

@edvbld This change can now be integrated. The commit message will be:

Add clean and images targets to Makefile

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 18, 2019
@openjdk openjdk bot closed this Oct 18, 2019
@openjdk openjdk bot added the integrated label Oct 18, 2019
@openjdk
Copy link

openjdk bot commented Oct 18, 2019

@edvbld
Pushed as commit 4cb344c.

@openjdk openjdk bot removed the ready label Oct 18, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2019

Mailing list message from Erik Helin ehelin@openjdk.org

Changeset: 4cb344c
Author: Erik Helin
Date: 2019-10-18 09:12:15 +0000
URL: https://git.openjdk.java.net/skara/commit/4cb344cb

Add clean and images targets to Makefile

Reviewed-by: rwestberg

! Makefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.