Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the HunkCoalescer again #214

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Oct 18, 2019

Hi all,

seems like the HunkCoalescer wasn't finished with me just yet. I forgot about some end-of-file use cases and also applied my previous fix in the wrong place. This time however it works, many thanks to @JornVernee for testing and reporting the additional bugs.

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Oct 18, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Very well, but I still think there should be a test or two for this. :)

@openjdk openjdk bot removed the rfr label Oct 18, 2019
@openjdk
Copy link

openjdk bot commented Oct 18, 2019

@edvbld This change can now be integrated. The commit message will be:

Fix the HunkCoalescer again

Reviewed-by: rwestberg, jvernee
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 18, 2019
@edvbld
Copy link
Member Author

edvbld commented Oct 21, 2019

/integrate

@openjdk openjdk bot closed this Oct 21, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 21, 2019
@openjdk
Copy link

openjdk bot commented Oct 21, 2019

@edvbld
Pushed as commit f265d88.

@mlbridge
Copy link

mlbridge bot commented Oct 21, 2019

Mailing list message from Erik Helin ehelin@openjdk.org

Changeset: f265d88
Author: Erik Helin
Date: 2019-10-21 06:34:53 +0000
URL: https://git.openjdk.java.net/skara/commit/f265d888

Fix the HunkCoalescer again

Reviewed-by: rwestberg, jvernee

! webrev/src/main/java/org/openjdk/skara/webrev/HunkCoalescer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.