409: pr set --no-draft fails on gitlab provider

[rwestberg]

Hi all,

Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster.

Best regards,
Robin

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-409: pr set --no-draft fails on gitlab provider

Reviewers

• Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219
$ git checkout pull/219

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 03: Full (275dc4c)
• 02: Full - Incremental (8ae453d)
• 01: Full - Incremental (f6c0004)
• 00: Full (16446a6)

[edvbld]

/integrate

[openjdk]

@edvbld Only the author (@rwestberg) is allowed to issue the integrate command.

[edvbld]

Looks good!

[openjdk]

@rwestberg This change is no longer ready for integration - check the PR body for details.

[edvbld]

/test

[openjdk]

@edvbld Unknown command test - for a list of valid commands use /help.

[openjdk]

Could not create test job

[edvbld]

/test

[openjdk]

@edvbld Unknown command test - for a list of valid commands use /help.

[openjdk]

A test job has been started with id: github.com-193500053-219-560444797

[edvbld]

/help

[openjdk]

@edvbld your test job with id github.com-193500053-219-560444797 for commits up until 9ef803b has finished.

[openjdk]

@edvbld Available commands:

• contributor - adds or removes additional contributors for a PR
• covered - Used when employer has signed the OCA
• help - shows this text
• integrate - performs integration of the changes in the PR
• signed - Used after signing the OCA
• solves - add an additional issue that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message

[edvbld]

/test

[openjdk]

@edvbld Unknown command test - for a list of valid commands use /help.

[openjdk]

A test job has been started with id: github.com-193500053-219-561106255

[openjdk]

@edvbld your test job with id github.com-193500053-219-561106255 for commits up until 275dc4c has finished.

[edvbld]

/test

[openjdk]

A test job has been started with id: github.com-193500053-219-561156400

[openjdk]

@edvbld your test job with id github.com-193500053-219-561156400 for commits up until 275dc4c has finished.

[edvbld]

/test

[openjdk]

A test job has been started with id: github.com-193500053-219-561217850

[openjdk]

@edvbld your test job with id github.com-193500053-219-561217850 for commits up until 275dc4c has finished.

[edvbld]

/test

[openjdk]

A test job has been started with id: github.com-193500053-219-561672541

[openjdk]

@edvbld your test job with id github.com-193500053-219-561672541 for commits up until 275dc4c has finished.

[edvbld]

Looks good!

[openjdk]

@rwestberg this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout avoid_lock
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[edvbld]

/issue add SKARA-409

[openjdk]

@edvbld Only the author (@rwestberg) is allowed to issue the /issue command.

[rwestberg]

/solves 409

[openjdk]

@rwestberg The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[bridgekeeper]

@rwestberg This pull request has been inactive for more than 3 weeks and will be automatically closed if another 3 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!