Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

409: pr set --no-draft fails on gitlab provider #219

Closed
wants to merge 5 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 21, 2019

Hi all,

Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-409: pr set --no-draft fails on gitlab provider

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219
$ git checkout pull/219

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Oct 21, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2019

Webrevs

@edvbld
Copy link
Member

@edvbld edvbld commented Oct 22, 2019

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2019

@edvbld Only the author (@rwestberg) is allowed to issue the integrate command.

edvbld
edvbld approved these changes Oct 22, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Oct 22, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2019

@rwestberg This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready label Oct 22, 2019
@openjdk openjdk bot added the bots label Oct 22, 2019
@edvbld
Copy link
Member

@edvbld edvbld commented Dec 2, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

@edvbld Unknown command test - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

Could not create test job

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 2, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

@edvbld Unknown command test - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

A test job has been started with id: github.com-193500053-219-560444797

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 2, 2019

/help

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

@edvbld your test job with id github.com-193500053-219-560444797 for commits up until 9ef803b has finished.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2019

@edvbld Available commands:

  • contributor - adds or removes additional contributors for a PR
  • covered - Used when employer has signed the OCA
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • signed - Used after signing the OCA
  • solves - add an additional issue that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 3, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

@edvbld Unknown command test - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

A test job has been started with id: github.com-193500053-219-561106255

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

@edvbld your test job with id github.com-193500053-219-561106255 for commits up until 275dc4c has finished.

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 3, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

A test job has been started with id: github.com-193500053-219-561156400

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

@edvbld your test job with id github.com-193500053-219-561156400 for commits up until 275dc4c has finished.

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 3, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

A test job has been started with id: github.com-193500053-219-561217850

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2019

@edvbld your test job with id github.com-193500053-219-561217850 for commits up until 275dc4c has finished.

@edvbld
Copy link
Member

@edvbld edvbld commented Dec 4, 2019

/test

@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2019

A test job has been started with id: github.com-193500053-219-561672541

@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2019

@edvbld your test job with id github.com-193500053-219-561672541 for commits up until 275dc4c has finished.

@openjdk openjdk bot added the rfr label Jan 24, 2020
edvbld
edvbld approved these changes Feb 20, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot added ready and removed ready labels Feb 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2020

@rwestberg this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout avoid_lock
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Jun 11, 2020
@edvbld
Copy link
Member

@edvbld edvbld commented Jun 11, 2020

/issue add SKARA-409

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2020

@edvbld Only the author (@rwestberg) is allowed to issue the /issue command.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jun 11, 2020

/solves 409

@openjdk openjdk bot changed the title No need for locking when using TestHostedRepository 409: pr set --no-draft fails on gitlab provider Jun 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2020

@rwestberg The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 29, 2020

@rwestberg This pull request has been inactive for more than 3 weeks and will be automatically closed if another 3 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@rwestberg rwestberg closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants