Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create forges from service providers #223

Closed
wants to merge 5 commits into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Oct 24, 2019

Hi all,

Please review this refactoring that allows forges to be created from service providers.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr cli build labels Oct 24, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2019

Webrevs

if (forge.isValid()) {
return Optional.of(forge);
}
} catch (RuntimeException ignored) {

This comment has been minimized.

@edvbld

edvbld Oct 24, 2019 Member

Maybe catch IllegalArgumentException instead? A bit more meaning than just RuntimeException :)

This comment has been minimized.

@rwestberg

rwestberg Oct 24, 2019 Author Member

Good point, I did a bit of cleaning up in the error handling for the isValid call.

@openjdk openjdk bot added the bots label Oct 24, 2019
@edvbld
edvbld approved these changes Oct 25, 2019
Copy link
Member

edvbld left a comment

Looks good, nice work!

@openjdk openjdk bot removed the rfr label Oct 25, 2019
@openjdk
Copy link

openjdk bot commented Oct 25, 2019

@rwestberg This change can now be integrated. The commit message will be:

Create forges from service providers

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • feb10a0: 142: The new_line field of a GitLab review comment can be null
  • c96d768: Add --recurse-submodules=on-demand to git fetch commands

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 25, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Oct 28, 2019

/integrate

@openjdk openjdk bot closed this Oct 28, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 28, 2019
@openjdk
Copy link

openjdk bot commented Oct 28, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • feb10a0: 142: The new_line field of a GitLab review comment can be null
  • c96d768: Add --recurse-submodules=on-demand to git fetch commands

Your commit was automatically rebased without conflicts.

Pushed as commit 6862091.

@mlbridge
Copy link

mlbridge bot commented Oct 28, 2019

Mailing list message from Robin Westberg rwestberg@openjdk.org

Changeset: 6862091
Author: Robin Westberg
Date: 2019-10-28 07:07:31 +0000
URL: https://git.openjdk.java.net/skara/commit/68620913

Create forges from service providers

Reviewed-by: ehelin

! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java
! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java
! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotSlackHandler.java
! cli/src/main/java/org/openjdk/skara/cli/GitFork.java
! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! forge/build.gradle
! forge/src/main/java/module-info.java
! forge/src/main/java/org/openjdk/skara/forge/Forge.java
! forge/src/main/java/org/openjdk/skara/forge/ForgeFactory.java

  • forge/src/main/java/org/openjdk/skara/forge/GitHubApplication.java
  • forge/src/main/java/org/openjdk/skara/forge/GitHubHost.java
  • forge/src/main/java/org/openjdk/skara/forge/GitHubPullRequest.java
  • forge/src/main/java/org/openjdk/skara/forge/GitHubRepository.java
  • forge/src/main/java/org/openjdk/skara/forge/GitLabHost.java
  • forge/src/main/java/org/openjdk/skara/forge/GitLabRepository.java
    ! forge/src/main/java/org/openjdk/skara/forge/PullRequestUpdateCache.java
  • forge/src/main/java/org/openjdk/skara/forge/github/GitHubApplication.java
  • forge/src/main/java/org/openjdk/skara/forge/github/GitHubForgeFactory.java
  • forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java
  • forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
  • forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java
    = forge/src/main/java/org/openjdk/skara/forge/github/PositionMapper.java
  • forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java
  • forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java
    = forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
  • forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java
  • forge/src/test/java/org/openjdk/skara/forge/ForgeTests.java
  • forge/src/test/java/org/openjdk/skara/forge/GitHubApplicationTests.java
  • forge/src/test/java/org/openjdk/skara/forge/GitHubHostTests.java
  • forge/src/test/java/org/openjdk/skara/forge/github/GitHubApplicationTests.java
  • forge/src/test/java/org/openjdk/skara/forge/github/GitHubHostTests.java
    = forge/src/test/java/org/openjdk/skara/forge/github/PositionMapperTests.java
  • host/src/main/java/org/openjdk/skara/host/Credential.java
  • host/src/main/java/org/openjdk/skara/host/PersonalAccessToken.java
    ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTrackerFactory.java
    ! network/src/main/java/org/openjdk/skara/network/RestRequest.java
    ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.