Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mime encoding #230

Closed
wants to merge 1 commit into from
Closed

Adjust mime encoding #230

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 29, 2019

Hi all,

Please review this minor change that adjusts the MIME encoding to better adhere to RFC1342.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Oct 29, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2019

Webrevs

edvbld
edvbld approved these changes Nov 4, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 4, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2019

@rwestberg This change can now be integrated. The commit message will be:

Adjust mime encoding

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 4, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 4, 2019

/integrate

@openjdk openjdk bot closed this Nov 4, 2019
@openjdk openjdk bot added the integrated label Nov 4, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2019

@rwestberg
Pushed as commit 7984f33.

@openjdk openjdk bot removed the ready label Nov 4, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 4, 2019

Mailing list message from Robin Westberg rwestberg@openjdk.org

Changeset: 7984f33
Author: Robin Westberg
Date: 2019-11-04 15:34:28 +0000
URL: https://git.openjdk.java.net/skara/commit/7984f332

Adjust mime encoding

Reviewed-by: ehelin

! email/src/main/java/org/openjdk/skara/email/MimeText.java
! email/src/test/java/org/openjdk/skara/email/MimeTextTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants