Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Jira authentication #232

Closed
wants to merge 3 commits into from
Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 1, 2019

Hi all,

Please review this change that implements Jira authentication using vault, as well as the remaining unimplemented methods that required authentication.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 1, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 1, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 1, 2019

Webrevs

edvbld
edvbld approved these changes Nov 4, 2019
Copy link
Member

@edvbld edvbld left a comment

Wow, this looks great Robin, nice work!

@openjdk openjdk bot removed the rfr label Nov 4, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2019

@rwestberg This change can now be integrated. The commit message will be:

Implement Jira authentication

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 8c37b49: Discard duplicate checks
  • 17f2684: Support the "neutral" check conclusion
  • 7984f33: Adjust mime encoding

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 4, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 5, 2019

/integrate

@openjdk openjdk bot closed this Nov 5, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 5, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 8c37b49: Discard duplicate checks
  • 17f2684: Support the "neutral" check conclusion
  • 7984f33: Adjust mime encoding

Your commit was automatically rebased without conflicts.

Pushed as commit 0e3e711.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2019

Mailing list message from Robin Westberg rwestberg@openjdk.org

Changeset: 0e3e711
Author: Robin Westberg
Date: 2019-11-05 10:36:46 +0000
URL: https://git.openjdk.java.net/skara/commit/0e3e7114

Implement Jira authentication

Reviewed-by: ehelin

! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssueTrackerFactory.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java

  • issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraVault.java
    ! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java
    ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java
    ! test/src/main/java/org/openjdk/skara/test/IssueData.java
    ! test/src/main/java/org/openjdk/skara/test/TestIssue.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants