Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "neutral" check conclusion #234

Merged
merged 1 commit into from Nov 5, 2019

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 5, 2019

Hi all,

Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 5, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2019

edvbld
edvbld approved these changes Nov 5, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, how about adding a fallthrough comment?

@@ -317,6 +317,7 @@ public ZonedDateTime updatedAt() {
checkBuilder.complete(true, completedAt);
break;
case "failure":
Copy link
Member

@edvbld edvbld Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case "failure":
case "failure":
// fallthrough

@openjdk openjdk bot removed the rfr label Nov 5, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2019

@rwestberg This change can now be integrated. The commit message will be:

Support the "neutral" check conclusion

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@rwestberg rwestberg merged commit 17f2684 into openjdk:master Nov 5, 2019
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants