Support the "neutral" check conclusion #234
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Webrevs
|
edvbld
approved these changes
Nov 5, 2019
| @@ -317,6 +317,7 @@ public ZonedDateTime updatedAt() { | |||
| checkBuilder.complete(true, completedAt); | |||
| break; | |||
| case "failure": | |||
There was a problem hiding this comment.
Suggested change
| case "failure": | |
| case "failure": | |
| // fallthrough |
|
@rwestberg This change can now be integrated. The commit message will be:
|
Reviewed-by: ehelin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API.
Best regards,
Robin
Progress
Approvers