Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "neutral" check conclusion #234

merged 1 commit into from Nov 5, 2019
Changes from all commits
File filter

Filter by extension

Filter by extension

Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -317,6 +317,8 @@ public Map<String, Check> checks(Hash hash) {
checkBuilder.complete(true, completedAt);
case "failure":
Copy link

@edvbld edvbld Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case "failure":
case "failure":
// fallthrough

// fallthrough
case "neutral":
checkBuilder.complete(false, completedAt);
@@ -342,7 +344,7 @@ public Map<String, Check> checks(Hash hash) {

public void createCheck(Check check) {
// update and create are currenly identical operations, both do an HTTP
// update and create are currently identical operations, both do an HTTP
// POST to the /repos/:owner/:repo/check-runs endpoint. There is an additional
// endpoint explicitly for updating check-runs, but that is not currently used.