Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

149: Improve formatting of bridged emails #236

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 5, 2019

Hi all,

Please review this change that improves the formatting of mailing list messages that are posted to PRs.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-149: Improve formatting of bridged emails

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2019

Webrevs

edvbld
edvbld approved these changes Nov 6, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 6, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2019

@rwestberg This change can now be integrated. The commit message will be:

149: Improve formatting of bridged emails

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 43f8ff2: Add "Required" title to jcheck-check only if it fails

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 6, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 6, 2019

/integrate

@openjdk openjdk bot closed this Nov 6, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 6, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 43f8ff2: Add "Required" title to jcheck-check only if it fails

Your commit was automatically rebased without conflicts.

Pushed as commit 12ced19.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 6, 2019

Mailing list message from Robin Westberg rwestberg@openjdk.org

Changeset: 12ced19
Author: Robin Westberg
Date: 2019-11-06 11:14:47 +0000
URL: https://git.openjdk.java.net/skara/commit/12ced194

149: Improve formatting of bridged emails

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! mailinglist/src/main/java/org/openjdk/skara/mailinglist/Mbox.java
! mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanList.java
! mailinglist/src/test/java/org/openjdk/skara/mailinglist/MailmanTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants