Add support for offline and local builds

[edvbld]

Hi all,

this patch adds much improved support for both offline and local builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the images plugin to support a local image which uses the JDK that is currently executing Gradle for producing the jlinked image.

I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything.

Thanks,
Erik

Testing

• Tested multiple variants of builds, including local, offline and default builds

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Robin Westberg (rwestberg - Reviewer) Note! Review applies to 66a6b56

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 05: Full - Incremental (4d96e1a)
• 04: Full - Incremental (b68a41a)
• 03: Full - Incremental (0707338)
• 02: Full - Incremental (ddccafd)
• 01: Full - Incremental (b70c527)
• 00: Full (66a6b56)

[edvbld]

@nick-arm could you please try this PR out and see if it works for you? If you have JDK 12 installed locally (or at least pointed to by JAVA_HOME) then you should just be able to run sh gradlew (see the updated README for details).

[edvbld]

@JornVernee could you give this a spin on Windows and see if it works?

[rwestberg]

Looks good, I think this approach sounds reasonable.

[openjdk]

@edvbld This change can now be integrated. The commit message will be:

Add support for offline and local builds

Co-authored-by: Nick Gasson <nick.gasson@arm.com>
Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch:

• 2cb3a2e: Use tag annotation if present when sending notifications
• 069620b: Add buildnum extraction support for OpenJFX tags
• e294ce9: Add ReadOnlyRepository.annotate(Tag t) method
• b1e3d87: 151: Encode single dot characters in the SMTP client
• f4cc08e: 148: Review comment general comment first
• 12ced19: 149: Improve formatting of bridged emails
• 43f8ff2: Add "Required" title to jcheck-check only if it fails
• 0d73a1f: 147: Update the "Changes required" message
• 0e3e711: Implement Jira authentication
• 8c37b49: Discard duplicate checks
• 17f2684: Support the "neutral" check conclusion

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

• To integrate this PR with the above commit message, type /integrate in a new comment.

[JornVernee]

Works for me with gradle 5.6.4 and JDK 12b33

[edvbld]

/co-author help

[openjdk]

@edvbld Unknown command co-author help - for a list of valid commands use /help.

[edvbld]

/contributor add Nick Gasson nick.gasson@arm.com

[openjdk]

@edvbld
Contributor Nick Gasson <nick.gasson@arm.com> successfully added.

[edvbld]

/integrate

[openjdk]

@edvbld The following commits have been pushed to master since your change was applied:

• 2cb3a2e: Use tag annotation if present when sending notifications
• 069620b: Add buildnum extraction support for OpenJFX tags
• e294ce9: Add ReadOnlyRepository.annotate(Tag t) method
• b1e3d87: 151: Encode single dot characters in the SMTP client
• f4cc08e: 148: Review comment general comment first
• 12ced19: 149: Improve formatting of bridged emails
• 43f8ff2: Add "Required" title to jcheck-check only if it fails
• 0d73a1f: 147: Update the "Changes required" message
• 0e3e711: Implement Jira authentication
• 8c37b49: Discard duplicate checks
• 17f2684: Support the "neutral" check conclusion

Your commit was automatically rebased without conflicts.

Pushed as commit f3881b6.

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

Changeset: f3881b6
Author: Erik Helin
Date: 2019-11-11 07:51:16 +0000
URL: https://git.openjdk.java.net/skara/commit/f3881b62

Add support for offline and local builds

Co-authored-by: Nick Gasson <nick.gasson at arm.com>
Reviewed-by: rwestberg

! README.md
! bots/cli/build.gradle
! build.gradle
! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java
! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LaunchersTask.java
! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LinkTask.java
! cli/build.gradle
! deps.env
! gradlew
! gradlew.bat