New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for offline and local builds #237
Conversation
|
Webrevs
|
@nick-arm could you please try this PR out and see if it works for you? If you have JDK 12 installed locally (or at least pointed to by |
@JornVernee could you give this a spin on Windows and see if it works? |
@edvbld This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 11 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge
|
Works for me with gradle 5.6.4 and JDK 12b33 |
buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Robin Westberg <robin@westberg.se>
Co-Authored-By: Robin Westberg <robin@westberg.se>
buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java
Show resolved
Hide resolved
/co-author help |
@edvbld Unknown command |
/contributor add Nick Gasson nick.gasson@arm.com |
@edvbld |
/integrate |
@edvbld The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit f3881b6. |
Mailing list message from Erik Helin on skara-dev: Changeset: f3881b6 Add support for offline and local builds Co-authored-by: Nick Gasson <nick.gasson at arm.com> ! README.md |
Hi all,
this patch adds much improved support for both offline and local builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the
images
plugin to support alocal
image which uses the JDK that is currently executing Gradle for producing the jlinked image.I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything.
Thanks,
Erik
Testing
Progress
Approvers