Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for offline and local builds #237

wants to merge 6 commits into from
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -123,7 +123,7 @@ def getOS() {

def getCPU() {
def cpu = System.getProperty('os.arch').toLowerCase()
This conversation was marked as resolved by edvbld

This comment has been minimized.

Copy link

JornVernee Nov 5, 2019

I think this is "x86_64" on Mac for 64 bit platforms (ran into that for Panama as well). So, I think you need to check for cpu.startsWith('amd64') || cpu.startsWith('x86_64') below.

This comment has been minimized.

Copy link

edvbld Nov 6, 2019

Author Member

Fixed, also added a check for "x64".

if (cpu.startsWith('amd64')) {
if (cpu.startsWith('amd64') || cpu.startsWith('x86_64') || cpu.startsWith('x64')) {
return 'x64'
if (cpu.startsWith('x86') || cpu.startsWith('i386')) {
@@ -53,7 +53,7 @@ private static String getOS() {

private static String getCPU() {
var p = System.getProperty("os.arch").toLowerCase();
if (p.startsWith("amd64")) {
if (p.startsWith("amd64") || p.startsWith("x86_64") || p.startsWith("x64")) {
return "x64";
if (p.startsWith("x86") || p.startsWith("i386")) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.