Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Required" title to jcheck-check only if it fails #238

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 6, 2019

Hi all,

please review this small patch that only sets the title "Required" for the jcheck-check if jcheck fails.

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 6, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 6, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 6, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2019

@edvbld This change can now be integrated. The commit message will be:

Add "Required" title to jcheck-check only if it fails

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 6, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Nov 6, 2019

/integrate

@openjdk openjdk bot closed this Nov 6, 2019
@openjdk openjdk bot added the integrated label Nov 6, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2019

@edvbld
Pushed as commit 43f8ff2.

@openjdk openjdk bot removed the ready label Nov 6, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 6, 2019

Mailing list message from Erik Helin ehelin@openjdk.org

Changeset: 43f8ff2
Author: Erik Helin
Date: 2019-11-06 11:09:07 +0000
URL: https://git.openjdk.java.net/skara/commit/43f8ff2b

Add "Required" title to jcheck-check only if it fails

Reviewed-by: rwestberg

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants