Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Required" title to jcheck-check only if it fails #238

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -171,6 +171,7 @@ private void updateCheckBuilder(CheckBuilder checkBuilder, PullRequestCheckIssue
if (visitor.isReadyForReview() && additionalErrors.isEmpty()) {
checkBuilder.complete(true);
} else {
checkBuilder.title("Required");
var summary = Stream.concat(visitor.getMessages().stream(), additionalErrors.stream())
.sorted()
.map(m -> "- " + m)
@@ -448,7 +449,6 @@ private void updateMergeReadyComment(boolean isReady, String commitMessage, List

private void checkStatus() {
var checkBuilder = CheckBuilder.create("jcheck", pr.headHash());
checkBuilder.title("Required");
var censusDomain = censusInstance.configuration().census().domain();
Exception checkException = null;