Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

151: Encode single dot characters in the SMTP client #240

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Nov 7, 2019

Hi all,

Please review this change that ensures that lines containing a single dot are properly escaped in the SMTP client.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-151: Encode single dot characters in the SMTP client

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 7, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 7, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 7, 2019

Webrevs

@edvbld
edvbld approved these changes Nov 7, 2019
Copy link
Member

edvbld left a comment

Thanks Robin for fixing this, looks good!

@openjdk openjdk bot removed the rfr label Nov 7, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 7, 2019

@rwestberg This change can now be integrated. The commit message will be:

151: Encode single dot characters in the SMTP client

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 7, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Nov 7, 2019

/integrate

@openjdk openjdk bot closed this Nov 7, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 7, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 7, 2019

@rwestberg
Pushed as commit b1e3d87.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 7, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: b1e3d87
Author: Robin Westberg
Date: 2019-11-07 10:59:57 +0000
URL: https://git.openjdk.java.net/skara/commit/b1e3d870

151: Encode single dot characters in the SMTP client

Reviewed-by: ehelin

! email/src/main/java/org/openjdk/skara/email/SMTP.java
! email/src/test/java/org/openjdk/skara/email/SMTPTests.java
! test/src/main/java/org/openjdk/skara/test/SMTPServer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.