Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag annotation if present when sending notifications #243

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -171,11 +171,6 @@ private void handleTags(Repository localRepo, UpdateHistory history) throws IOEx
.map(Optional::get)
.sorted(Comparator.comparingInt(OpenJDKTag::buildNum))
.collect(Collectors.toList());

var newNonJdkTags = newTags.stream()
.filter(tag -> OpenJDKTag.create(tag).isEmpty())
.collect(Collectors.toList());

for (var tag : newJdkTags) {
// Update the history first - if there is a problem here we don't want to send out multiple updates
history.addTags(List.of(tag.tag()));
@@ -205,6 +200,9 @@ private void handleTags(Repository localRepo, UpdateHistory history) throws IOEx
}
}

var newNonJdkTags = newTags.stream()
.filter(tag -> OpenJDKTag.create(tag).isEmpty())
.collect(Collectors.toList());
for (var tag : newNonJdkTags) {
// Update the history first - if there is a problem here we don't want to send out multiple updates
history.addTags(List.of(tag));