Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 6.0 #246

Closed
wants to merge 1 commit into from
Closed

Update to Gradle 6.0 #246

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 11, 2019

Hi all,

please review this patch that updates Gradle to version 6.0. I had to fix two minor deprecation warnings:

  • runtime -> runtimeOnly
  • version -> archiveVersion

Thanks,
Erik

Testing

  • sh gradlew test --warning-mode all
  • sh gradlew images --warning-mode all
  • Various manual testing of different build targets

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2019

@edvbld This change can now be integrated. The commit message will be:

Update to Gradle 6.0

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 11, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Nov 11, 2019

/integrate

@openjdk openjdk bot closed this Nov 11, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2019

@edvbld
Pushed as commit 49bbd41.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 49bbd41
Author: Erik Helin
Date: 2019-11-11 13:23:45 +0000
URL: https://git.openjdk.java.net/skara/commit/49bbd418

Update to Gradle 6.0

Reviewed-by: rwestberg

! buildSrc/build.gradle
! cli/build.gradle
! deps.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants