Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request prune functionality #247

Closed
wants to merge 3 commits into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Nov 11, 2019

Hi all,

Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer) Note! Review applies to 83c4142
  • Kevin Rushforth (kcr - no project role)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Nov 11, 2019
@edvbld
edvbld approved these changes Nov 11, 2019
Copy link
Member

edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 11, 2019
@openjdk
Copy link

openjdk bot commented Nov 11, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add pull request prune functionality

Reviewed-by: ehelin, kcr
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 11, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2019

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 11, 2019

What is the motivation for doing this? I'm not sure that I would find this a useful behavior.

@rwestberg
Copy link
Member Author

rwestberg commented Nov 11, 2019

This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs.

@rwestberg
Copy link
Member Author

rwestberg commented Nov 11, 2019

After discussing this a bit with Kevin offline, I've updated the logic to send an initial notice before proceeding with the actual close.

@rwestberg
Copy link
Member Author

rwestberg commented Nov 11, 2019

@edvbld Please have another look!

Copy link
Member

kevinrushforth left a comment

Looks good.

@rwestberg
Copy link
Member Author

rwestberg commented Nov 12, 2019

@kevinrushforth Thanks for reviewing!

@rwestberg
Copy link
Member Author

rwestberg commented Nov 12, 2019

/integrate

@openjdk openjdk bot closed this Nov 12, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 12, 2019
@openjdk
Copy link

openjdk bot commented Nov 12, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.

Pushed as commit e75c0b0.

@mlbridge
Copy link

mlbridge bot commented Nov 12, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: e75c0b0
Author: Robin Westberg
Date: 2019-11-12 13:18:36 +0000
URL: https://git.openjdk.java.net/skara/commit/e75c0b06

Add pull request prune functionality

Reviewed-by: ehelin, kcr

  • bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBot.java
    ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotFactory.java
  • bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java
  • bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBot.java
  • bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotTests.java
  • bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBotTests.java
  • bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBotTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.