Add pull request prune functionality

[rwestberg]

Hi all,

Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity.

Best regards,
Robin

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Erik Helin (ehelin - Reviewer) Note! Review applies to 83c4142
• Kevin Rushforth (kcr - no project role)

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[edvbld]

Looks good!

[openjdk]

@rwestberg This change can now be integrated. The commit message will be:

Add pull request prune functionality

Reviewed-by: ehelin, kcr

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• 56b9f65: Update to JDK 13.0.1
• 980b7a8: Add tester bot and ci module

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

• To integrate this PR with the above commit message, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (fa681f0)
• 01: Full - Incremental (9983c27)
• 00: Full (83c4142)

[kevinrushforth]

What is the motivation for doing this? I'm not sure that I would find this a useful behavior.

[rwestberg]

This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs.

[rwestberg]

After discussing this a bit with Kevin offline, I've updated the logic to send an initial notice before proceeding with the actual close.

[rwestberg]

@edvbld Please have another look!

[kevinrushforth]

Looks good.

[rwestberg]

@kevinrushforth Thanks for reviewing!

[rwestberg]

/integrate

[openjdk]

@rwestberg The following commits have been pushed to master since your change was applied:

• 56b9f65: Update to JDK 13.0.1
• 980b7a8: Add tester bot and ci module

Your commit was automatically rebased without conflicts.

Pushed as commit e75c0b0.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: e75c0b0
Author: Robin Westberg
Date: 2019-11-12 13:18:36 +0000
URL: https://git.openjdk.java.net/skara/commit/e75c0b06

Add pull request prune functionality

Reviewed-by: ehelin, kcr

• bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBot.java
  ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotFactory.java

• bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java
• bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBot.java

• bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotTests.java

• bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBotTests.java
• bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBotTests.java