Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tester bot and ci module #248

Closed
wants to merge 1 commit into from
Closed

Add tester bot and ci module #248

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 11, 2019

Hi all,

please review this slightly larger patch that adds the tester bot and the ci module. The tester is the bot supporting the /test command in a PR, for example writing /test tier1. I wanted to name the bot test but it was to annoying to get that work with the already present test module 馃槂

Thanks,
Erik

Testing

  • sh gradlew test passes on Linux x64
  • Added a bunch of new unit tests for the tester bot (ci module is just an interface)
  • Manually tested to deploy the bot

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2019

馃憢 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

if (ci.isPresent()) {
ret.put(entry.name(), ci.get());
} else {
throw new ConfigurationError("No continuous integration named with url: " + url);
Copy link
Member

@rwestberg rwestberg Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new ConfigurationError("No continuous integration named with url: " + url);
throw new ConfigurationError("No continuous integration could be created from url: " + url);

@openjdk openjdk bot removed the rfr label Nov 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2019

@edvbld This change can now be integrated. The commit message will be:

Add tester bot and ci module

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 11, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Nov 12, 2019

/integrate

@openjdk openjdk bot closed this Nov 12, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 12, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2019

@edvbld
Pushed as commit 980b7a8.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 980b7a8
Author: Erik Helin
Date: 2019-11-12 09:01:57 +0000
URL: https://git.openjdk.java.net/skara/commit/980b7a87

Add tester bot and ci module

Reviewed-by: rwestberg

! bot/build.gradle
! bot/src/main/java/module-info.java
! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java
! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java
! bots/bridgekeeper/build.gradle
! bots/cli/build.gradle
! bots/forward/build.gradle
! bots/hgbridge/build.gradle
! bots/merge/build.gradle
! bots/mirror/build.gradle
! bots/mlbridge/build.gradle
! bots/notify/build.gradle
! bots/pr/build.gradle
! bots/submit/build.gradle

  • bots/tester/build.gradle
  • bots/tester/src/main/java/module-info.java
  • bots/tester/src/main/java/org/openjdk/skara/bots/tester/Stage.java
  • bots/tester/src/main/java/org/openjdk/skara/bots/tester/State.java
  • bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java
  • bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBotFactory.java
  • bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestWorkItem.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryContinuousIntegration.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHost.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHostedRepository.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryJob.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/StateTests.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestBotTests.java
  • bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestWorkItemTests.java
    ! bots/topological/build.gradle
  • ci/build.gradle
  • ci/src/main/java/module-info.java
  • ci/src/main/java/org/openjdk/skara/ci/Build.java
  • ci/src/main/java/org/openjdk/skara/ci/ContinuousIntegration.java
  • ci/src/main/java/org/openjdk/skara/ci/ContinuousIntegrationFactory.java
  • ci/src/main/java/org/openjdk/skara/ci/Job.java
  • ci/src/main/java/org/openjdk/skara/ci/Test.java
    ! settings.gradle
    ! test/build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants