Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JDK 13.0.1 #249

Closed
wants to merge 1 commit into from
Closed

Update to JDK 13.0.1 #249

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 11, 2019

Hi all,

please review this small patch that updates to JDK 13.0.1 馃帀

Thanks,
Erik

Testing

  • sh gradlew images passes
  • sh gradlew test passes on Linux x64

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2019

馃憢 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Good stuff!

@openjdk openjdk bot removed the rfr label Nov 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2019

@edvbld This change can now be integrated. The commit message will be:

Update to JDK 13.0.1

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 980b7a8: Add tester bot and ci module

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 11, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Nov 12, 2019

/integrate

@openjdk openjdk bot closed this Nov 12, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 12, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2019

@edvbld The following commits have been pushed to master since your change was applied:

  • 980b7a8: Add tester bot and ci module

Your commit was automatically rebased without conflicts.

Pushed as commit 56b9f65.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 56b9f65
Author: Erik Helin
Date: 2019-11-12 09:07:06 +0000
URL: https://git.openjdk.java.net/skara/commit/56b9f651

Update to JDK 13.0.1

Reviewed-by: rwestberg

! bots/cli/build.gradle
! cli/build.gradle
! deps.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants