Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages when a reviewer isn't a project member #250

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -319,7 +319,7 @@ private String projectRole(Contributor contributor) {
} else if (censusInstance.project().isAuthor(contributor.username(), version)) {
return "Author";
}
return "none";
return "no project role";
}

void addReview(Review review) {
@@ -356,7 +356,7 @@ void addReviewVerdict(Review review) {
}

var userName = contributor != null ? contributor.username() : review.reviewer().userName() + "@" + censusInstance.namespace().name();
var userRole = contributor != null ? projectRole(contributor) : "no project role";
var userRole = contributor != null ? projectRole(contributor) : "no OpenJDK username";
var replyBody = ArchiveMessages.reviewVerdictBody(review.body().orElse(""), review.verdict(), userName, userRole);

addReplyCommon(parent, review.reviewer(), subject, replyBody, id);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.