Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bridgekeeper dependency #252

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 12, 2019

Hi all,

Please review this final change regarding proper bridgekeeper bot dependencies.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 12, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2019

Webrevs

edvbld
edvbld approved these changes Nov 12, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 12, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add missing bridgekeeper dependency

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 12, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 12, 2019

/integrate

@openjdk openjdk bot closed this Nov 12, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 12, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2019

@rwestberg
Pushed as commit f7e71e6.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: f7e71e6
Author: Robin Westberg
Date: 2019-11-12 14:36:15 +0000
URL: https://git.openjdk.java.net/skara/commit/f7e71e62

Add missing bridgekeeper dependency

Reviewed-by: ehelin

! bots/cli/build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants