Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MimeText conformance #255

Closed
wants to merge 1 commit into from
Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 18, 2019

Hi all,

Please review this change that improves the conformance of the MimeText encoder. Notably, create encode tokens at word boundaries and encode spaces between tokens.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 18, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 18, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 18, 2019

Webrevs

edvbld
edvbld approved these changes Nov 18, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 18, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2019

@rwestberg This change can now be integrated. The commit message will be:

Improve MimeText conformance

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 47f068b: git-sync --fetch is a no-op
  • 83f70fd: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 18, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 18, 2019

Thanks for reviewing!

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 20, 2019

/integrate

@openjdk openjdk bot closed this Nov 20, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 20, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 47f068b: git-sync --fetch is a no-op
  • 83f70fd: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java

Your commit was automatically rebased without conflicts.

Pushed as commit 483310e.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 20, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: 483310e
Author: Robin Westberg
Date: 2019-11-20 12:53:23 +0000
URL: https://git.openjdk.java.net/skara/commit/483310ea

Improve MimeText conformance

Reviewed-by: ehelin

! email/src/main/java/org/openjdk/skara/email/MimeText.java
! email/src/test/java/org/openjdk/skara/email/MimeTextTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants