Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-sync --fetch is a no-op #256

Closed
wants to merge 2 commits into from
Closed

Conversation

@edvbld
Copy link
Member

edvbld commented Nov 18, 2019

Hi all,

please review this smallp patch that just removes the --fetch option from git-sync. The option is not needed since git-sync always implicitly does a fetch, so there is no point in providing this flag.

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 18, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr cli labels Nov 18, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 18, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 19, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 19, 2019

@edvbld This change can now be integrated. The commit message will be:

git-sync --fetch is a no-op

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 83f70fd: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 19, 2019
@edvbld

This comment has been minimized.

Copy link
Member Author

edvbld commented Nov 19, 2019

/integrate

@openjdk openjdk bot closed this Nov 19, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 19, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 19, 2019

@edvbld The following commits have been pushed to master since your change was applied:

  • 83f70fd: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java

Your commit was automatically rebased without conflicts.

Pushed as commit 47f068b.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 19, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 47f068b
Author: Erik Helin
Date: 2019-11-19 14:23:24 +0000
URL: https://git.openjdk.java.net/skara/commit/47f068b9

git-sync --fetch is a no-op

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSync.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.