Query GitHub for current user when using PAT #258
Closed
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this patch that queries GitHub for the current user when using a PAT as credentials with
GitHubHost.java
. The reason for this is that some credentials manager, in particular Git Credential Manager on Windows, always seems to return "PersonalAccessToken" as the username when callinggit credential fill
. The fix is simple, just query the /user endoint instead of /users.Thanks,
Erik
Testing
git pr
and PAT on Linux x64 with a bogus username in credential store.Progress
Approvers