Query GitHub for current user when using PAT

[edvbld]

Hi all,

please review this patch that queries GitHub for the current user when using a PAT as credentials with GitHubHost.java. The reason for this is that some credentials manager, in particular Git Credential Manager on Windows, always seems to return "PersonalAccessToken" as the username when calling git credential fill. The fix is simple, just query the /user endoint instead of /users.

Thanks,
Erik

Testing

• Manual testing with git pr and PAT on Linux x64 with a bogus username in credential store.

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Robin Westberg (rwestberg - Reviewer)

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[edvbld]

Thanks @RealCLanger for helping out with debugging this!

[mlbridge]

Webrevs

• 00: Full (6a472c7)

[rwestberg]

Looks good!

[openjdk]

@edvbld This change can now be integrated. The commit message will be:

Query GitHub for current user when using PAT

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• 483310e: Improve MimeText conformance
• 47f068b: git-sync --fetch is a no-op

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

• To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld The following commits have been pushed to master since your change was applied:

• 483310e: Improve MimeText conformance
• 47f068b: git-sync --fetch is a no-op

Your commit was automatically rebased without conflicts.

Pushed as commit 2881d91.

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

Changeset: 2881d91
Author: Erik Helin
Date: 2019-11-20 14:37:02 +0000
URL: https://git.openjdk.java.net/skara/commit/2881d91f

Query GitHub for current user when using PAT

Reviewed-by: rwestberg

! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java