Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40: Fix failing tests after remote locking #26

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Jul 3, 2019

Hi all,

Please remove this test-only fix that removes a few failures introduced by the recent credentials lock method update.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@openjdk openjdk bot added bots rfr labels Jul 3, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

mlbridge bot commented Jul 3, 2019

Webrevs

@mlbridge
Copy link

mlbridge bot commented Jul 3, 2019

Mailing list message from Robin Westberg robin.westberg@oracle.com

Hi again,

First ?remove" was intended to be ?review?!

Best regards,
Robin

On 3 Jul 2019, at 16:03, Robin Westberg via github.com wrote:

Hi all,

Please remove this test-only fix that removes a few failures introduced by the recent credentials lock method update.

Best regards,
Robin


Commits:

  • 928eb72: Retain credentials lock when using pushAll

Pull request:
http://git.openjdk.java.net/skara/pull/26

Webrev:
https://openjdk.github.io/cr/skara/26/webrev.00

Patch:
http://git.openjdk.java.net/skara/pull/26.diff

Fetch command:
git fetch https://github.com/openjdk/skara.git pull/26/head:pull/26

@edvbld
edvbld approved these changes Jul 3, 2019
Copy link
Member

edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jul 3, 2019
@openjdk
Copy link

openjdk bot commented Jul 3, 2019

@rwestberg This change can now be integrated. The commit message will be:

40: Fix failing tests after remote locking

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jul 3, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Jul 4, 2019

/integrate

@openjdk openjdk bot closed this Jul 4, 2019
@openjdk
Copy link

openjdk bot commented Jul 4, 2019

@rwestberg Pushed as commit 7c68b3b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.