Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Jira 4xx errors different from 5xx #261

wants to merge 1 commit into from
Changes from all commits
File filter

Filter by extension

Filter by extension

Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -116,8 +116,11 @@ public Optional<Issue> issue(String id) {
var issueRequest = request.restrict("issue/" + id);
var issue = issueRequest.get("")
.onError(r -> r.statusCode() == 404 ? JSON.object().put("NOT_FOUND", true) : null)
.onError(r -> r.statusCode() < 500 ? JSON.object().put("NOT_FOUND", true) : null)
if (issue == null) {
throw new RuntimeException("Server error when trying to fetch issue " + id);
if (!issue.contains("NOT_FOUND")) {
return Optional.of(new JiraIssue(this, issueRequest, issue));
} else {