Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166: Add /solves command #264

Closed
wants to merge 1 commit into from
Closed

166: Add /solves command #264

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 22, 2019

Hi all,

Please review this change that implements the /solves command, which allows a PR to reference more than one issue.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-166: Add /solves command

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2019

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 22, 2019

Please note that this implementation does not updated the "Issue" list in the summary. As this is only a cosmetic change and does not affect the actual functionality, it will be done in a separate PR.

edvbld
edvbld approved these changes Nov 22, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 22, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2019

@rwestberg This change can now be integrated. The commit message will be:

166: Add `/solves` command

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 2f8cfc9: git-sync should use APIs to find upstream

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 22, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 22, 2019

/integrate

@openjdk openjdk bot closed this Nov 22, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 22, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 2f8cfc9: git-sync should use APIs to find upstream

Your commit was automatically rebased without conflicts.

Pushed as commit a77b854.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: a77b854
Author: Robin Westberg
Date: 2019-11-22 13:52:53 +0000
URL: https://git.openjdk.java.net/skara/commit/a77b854b

166: Add /solves command

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java

  • bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesCommand.java
  • bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesTracker.java
  • bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java
    ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants