Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166: Update PR status in body with multiple issues if needed #265

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Nov 22, 2019

Hi all,

Please review this change that ensures that the status in the PR body is correctly updated when the /solves command is used.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-166: Add /solves command

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 22, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Nov 22, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 22, 2019

Webrevs

@edvbld
edvbld approved these changes Nov 25, 2019
Copy link
Member

edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 25, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 25, 2019

@rwestberg This change can now be integrated. The commit message will be:

166: Update PR status in body with multiple issues if needed

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 25, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Nov 25, 2019

/integrate

@openjdk openjdk bot closed this Nov 25, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 25, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 25, 2019

@rwestberg
Pushed as commit 943987f.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 25, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: 943987f
Author: Robin Westberg
Date: 2019-11-25 07:00:52 +0000
URL: https://git.openjdk.java.net/skara/commit/943987fb

166: Update PR status in body with multiple issues if needed

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.