Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure Python 3 compatibility for the hg extension #267
Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again.
Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion.
@rwestberg This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 4 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge
@rwestberg The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts.
Pushed as commit 59405b7.
Ensure Python 3 compatibility for the hg extension