Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setTitle for GitLab merge requests #268

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Nov 25, 2019

Hi all,

Please review this minor change that implements the setTitle function for GitLab merge requests.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 25, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2019

Webrevs

@edvbld
edvbld approved these changes Nov 25, 2019
Copy link
Member

edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 25, 2019
@openjdk
Copy link

openjdk bot commented Nov 25, 2019

@rwestberg This change can now be integrated. The commit message will be:

Implement setTitle for GitLab merge requests

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 6ef6468: 169: If there are no changes after squashing, jcheck should fail

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 25, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Nov 25, 2019

/integrate

@openjdk openjdk bot closed this Nov 25, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 25, 2019
@openjdk
Copy link

openjdk bot commented Nov 25, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 6ef6468: 169: If there are no changes after squashing, jcheck should fail

Your commit was automatically rebased without conflicts.

Pushed as commit 0742126.

@mlbridge
Copy link

mlbridge bot commented Nov 25, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: 0742126
Author: Robin Westberg
Date: 2019-11-25 13:10:38 +0000
URL: https://git.openjdk.java.net/skara/commit/07421268

Implement setTitle for GitLab merge requests

Reviewed-by: ehelin

! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.