Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub's new review comment positioning API #269

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 25, 2019

Hi all,

Please review this change that switches to GitHub's new review comment positioning API. This removes the need for calculating line numbers based on position in the textual diff. Note that support for multi-line comments is not yet done (such comments will be shown as positioned on the last line). We can probably wait a bit with implementing that, as the API is technically still in preview.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

mlbridge bot commented Nov 25, 2019

Webrevs

edvbld
edvbld approved these changes Nov 26, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, very nice to get rid of the position mapper code!

@openjdk openjdk bot removed the rfr label Nov 26, 2019
@openjdk
Copy link

openjdk bot commented Nov 26, 2019

@rwestberg This change can now be integrated. The commit message will be:

Switch to GitHub's new review comment positioning API

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 59405b7: Ensure Python 3 compatibility for the hg extension

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 26, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Nov 26, 2019

/integrate

@openjdk openjdk bot closed this Nov 26, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 26, 2019
@openjdk
Copy link

openjdk bot commented Nov 26, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

  • 59405b7: Ensure Python 3 compatibility for the hg extension

Your commit was automatically rebased without conflicts.

Pushed as commit fe273af.

@mlbridge
Copy link

mlbridge bot commented Nov 26, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: fe273af
Author: Robin Westberg
Date: 2019-11-26 08:46:57 +0000
URL: https://git.openjdk.java.net/skara/commit/fe273afe

Switch to GitHub's new review comment positioning API

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java

  • forge/src/main/java/org/openjdk/skara/forge/github/PositionMapper.java
  • forge/src/test/java/org/openjdk/skara/forge/github/PositionMapperTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants