Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41: Bot launcher should detect ev. http proxy in environment #27

Closed
wants to merge 2 commits into from

Conversation

@edvbld
Copy link
Member

edvbld commented Jul 4, 2019

Hi all,

this patch ensures that BotLauncher.java correctly sets up corresponding system properties for http_proxy, https_proxy and no_proxy. The patch became a little larger than I intended since I had to break out HttpProxy into a new module and package to share it between cli and bots/cli. I also updated the Gradle ProxyPlugin to align with the new proxy module (there is unfortunately now way to use HttpProxy from the Gradle ProxyPlugin).

Thanks,
Erik

Testing

  • Executed sh gradlew test successfully on Linux

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added cli bots build rfr labels Jul 4, 2019
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

proxy/build.gradle Outdated Show resolved Hide resolved
@openjdk openjdk bot removed the rfr label Jul 4, 2019
@openjdk
Copy link

openjdk bot commented Jul 4, 2019

@edvbld This change can now be integrated. The commit message will be:

41: Bot launcher should detect ev. http proxy in environment

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 7c68b3b: 40: Fix failing tests after remote locking

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jul 4, 2019
Co-Authored-By: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

edvbld commented Jul 4, 2019

Thanks for reviewing @rwestberg!

@edvbld
Copy link
Member Author

edvbld commented Jul 4, 2019

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 965be9c.

@openjdk openjdk bot closed this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.