Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of issue updater #273

Closed
wants to merge 2 commits into from
Closed

Conversation

@rwestberg
Copy link
Member

rwestberg commented Nov 27, 2019

Hi all,

Please review this change that adds the first version of an issue updater (similar to what hgupdater currently provides for mercurial repositories).

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 27, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Nov 27, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 27, 2019

Webrevs

@edvbld
edvbld approved these changes Nov 27, 2019
Copy link
Member

edvbld left a comment

Very nice work Robin! So nice to see all the pieces fit into place 😃

I would probably have dropped the commit prefix from CommitFormatters.commitToText and CommitFormatters.commitToTextBrief, so that the methods instead read CommitFormatters.toText and CommitFormatters.toTextBrief. Since they are static it is clear at the call sites that a commit is being formatted.

@openjdk openjdk bot removed the rfr label Nov 27, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 27, 2019

@rwestberg This change can now be integrated. The commit message will be:

Initial version of issue updater

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 27, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Nov 27, 2019

Sure, can change that!

@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Nov 27, 2019

/integrate

@openjdk openjdk bot closed this Nov 27, 2019
@openjdk openjdk bot added the integrated label Nov 27, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Nov 27, 2019

@rwestberg
Pushed as commit f3afc99.

@openjdk openjdk bot removed the ready label Nov 27, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 27, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: f3afc99
Author: Robin Westberg
Date: 2019-11-27 12:15:39 +0000
URL: https://git.openjdk.java.net/skara/commit/f3afc994

Initial version of issue updater

Reviewed-by: ehelin

  • bots/notify/src/main/java/org/openjdk/skara/bots/notify/CommitFormatters.java
  • bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
    ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java
    ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
    ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.