Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

174: git-webrev should support taking file list via STDIN #276

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Nov 28, 2019

Hi all,

please review this small patch that adds support for git-webrev to take the list of files that should be included via STDIN.

Thanks,
Erik

Testing

  • Manual testing of git-webrev and passing files to include via STDIN

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-174: git-webrev should support taking file list via STDIN

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr cli labels Nov 28, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Nov 28, 2019
@openjdk
Copy link

openjdk bot commented Nov 28, 2019

@edvbld This change can now be integrated. The commit message will be:

174: git-webrev should support taking file list via STDIN

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 28, 2019
@edvbld
Copy link
Member Author

edvbld commented Nov 28, 2019

/integrate

@openjdk openjdk bot closed this Nov 28, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 28, 2019
@openjdk
Copy link

openjdk bot commented Nov 28, 2019

@edvbld
Pushed as commit 0571c60.

@mlbridge
Copy link

mlbridge bot commented Nov 28, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 0571c60
Author: Erik Helin <ehelin at openjdk.org>
Date: 2019-11-28 11:16:04 +0000
URL: https://git.openjdk.java.net/skara/commit/0571c60a

174: git-webrev should support taking file list via STDIN

Reviewed-by: rwestberg

! args/src/main/java/org/openjdk/skara/args/ArgumentParser.java
! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.