Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https:// everywhere #277

Closed
wants to merge 1 commit into from
Closed

Use https:// everywhere #277

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 28, 2019

Hi all,

please review this small patch that ensures what we use https:// links in all our Markdown generated by the bots.

Thanks,
Erik

Testing

  • make test on Linux x64

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 28, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 28, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Nov 28, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 28, 2019

@edvbld This change can now be integrated. The commit message will be:

Use https:// everywhere

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 28, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Nov 28, 2019

/integrate

@openjdk openjdk bot closed this Nov 28, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 28, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Nov 28, 2019

@edvbld
Pushed as commit 0057900.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 28, 2019

Mailing list message from Erik Helin on skara-dev:

Changeset: 0057900
Author: Erik Helin <ehelin at openjdk.org>
Date: 2019-11-28 14:45:25 +0000
URL: https://git.openjdk.java.net/skara/commit/00579009

Use https:// everywhere

Reviewed-by: rwestberg

! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants