Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https:// everywhere #277

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -56,7 +56,7 @@ private void checkWelcomeMessage() {
"This repository is currently a read-only git mirror of the official Mercurial " +
"repository (located at https://hg.openjdk.java.net/). As such, we are not " +
"currently accepting pull requests here. If you would like to contribute to " +
"the OpenJDK project, please see http://openjdk.java.net/contribute/ on how " +
"the OpenJDK project, please see https://openjdk.java.net/contribute/ on how " +
"to proceed.\n\n" +
"This pull request will be automatically closed.";

@@ -402,13 +402,13 @@ private String getMergeReadyComment(String commitMessage, List<Review> reviews,
message.append("\n");
var contributor = censusInstance.namespace().get(pr.author().id());
if (contributor == null) {
message.append("As you are not a known OpenJDK [Author](http://openjdk.java.net/bylaws#author), ");
message.append("As you are not a known OpenJDK [Author](https://openjdk.java.net/bylaws#author), ");
} else {
message.append("As you do not have Committer status in this project, ");
}

message.append("an existing [Committer](http://openjdk.java.net/bylaws#committer) must agree to ");
message.append("[sponsor](http://openjdk.java.net/sponsor/) your change. ");
message.append("an existing [Committer](https://openjdk.java.net/bylaws#committer) must agree to ");
message.append("[sponsor](https://openjdk.java.net/sponsor/) your change. ");
var candidates = reviews.stream()
.filter(review -> ProjectPermissions.mayCommit(censusInstance, review.reviewer()))
.map(review -> "@" + review.reviewer().userName())
@@ -37,7 +37,7 @@ public void handle(PullRequest pr, CensusInstance censusInstance, Path scratchPa
return;
}
if (!ProjectPermissions.mayReview(censusInstance, comment.author())) {
reply.println("Only [Reviewers](http://openjdk.java.net/bylaws#reviewer) are allowed to reject changes.");
reply.println("Only [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to reject changes.");
return;
}

@@ -42,7 +42,7 @@ public void handle(PullRequest pr, CensusInstance censusInstance, Path scratchPa
return;
}
if (!ProjectPermissions.mayCommit(censusInstance, comment.author())) {
reply.println("Only [Committers](http://openjdk.java.net/bylaws#committer) are allowed to sponsor changes.");
reply.println("Only [Committers](https://openjdk.java.net/bylaws#committer) are allowed to sponsor changes.");
return;
}