44: GitHubApplication should not use a JSONParser instance

[edvbld]

Hi all,

a JSONParser instance is not thread-safe and it is therefore a little dangerous to create instances of it if that instance might end up being accessible by multiple threads. We have such a case in GitHubApplication. Since a JSONParser is very cheap to allocate (it only has an int and a pointer) I decided to make JSONParser package private thereby forcing all callers to use JSON.parse.

Thanks,
Erik

Testing

• sh gradlew test on Linux x86-64

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Robin Westberg (rwestberg - Reviewer)

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 00: Full (19e2393)

[rwestberg]

Looks good, thanks for fixing!

[openjdk]

@edvbld This change can now be integrated. The commit message will be:

44: GitHubApplication should not use a JSONParser instance

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.
• To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld Pushed as commit 6746b03.