44: GitHubApplication should not use a JSONParser instance #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
a
JSONParser
instance is not thread-safe and it is therefore a little dangerous to create instances of it if that instance might end up being accessible by multiple threads. We have such a case inGitHubApplication
. Since aJSONParser
is very cheap to allocate (it only has anint
and a pointer) I decided to makeJSONParser
package private thereby forcing all callers to useJSON.parse
.Thanks,
Erik
Testing
sh gradlew test
on Linux x86-64Progress
Approvers