Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45: Fix remaining integration test issues #31

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 5, 2019

Hi all,

Please review this fix that improves the error message when an incorrect repository is encountered in a merge PR, as well as adjusting the tests.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 5, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 5, 2019

Webrevs

edvbld
edvbld approved these changes Jul 5, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Jul 5, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2019

@rwestberg This change can now be integrated. The commit message will be:

45: Fix remaining integration test issues

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 6746b03: 44: GitHubApplication should not use a JSONParser instance
  • 90edbab: 43: Repository.get should return Optional.empty on non-existing directory
  • e83e473: 42: Notifier tests can fail depending on execution order

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 5, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 5, 2019

/integrate

@openjdk openjdk bot closed this Jul 5, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 53a6c51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants