Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test mailserver logging #327

Closed
wants to merge 3 commits into from
Closed

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Dec 13, 2019

Hi all,

Please review this minor change that adds a bit of logging.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 13, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@rwestberg rwestberg changed the title Investigating test failure (does not reproduce locally) Add test mailserver logging Jan 15, 2020
@rwestberg rwestberg marked this pull request as ready for review Jan 15, 2020
@openjdk openjdk bot added the rfr label Jan 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2020

Webrevs

edvbld
edvbld approved these changes Jan 15, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Add test mailserver logging

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 30 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 15, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 15, 2020

/integrate

@openjdk openjdk bot closed this Jan 15, 2020
@openjdk openjdk bot added the integrated label Jan 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 0d1c64f: Improve formatting of ready-for-merge message
  • fd51409: Propagate issue properties when creating backports
  • d9bc4cc: 226: Fewer default columns for git pr list
  • d0cc3d7: 227: Increase timeout on getting feedback for /test and /integrate
  • 72c93f0: 224: Add --no-draft flag to git pr list
  • 9c67b6d: Allow unsafe features when importing
  • 7d878e7: 222: Implement backport issue creation
  • af856f5: 216: git-pr: show response to test and integrate commands
  • 3c8b6bc: 215: Verify webrev links before considering publication successful
  • ec7cd48: 219: Missing slash before CONTRIBUTING link in /integrate message
  • f0eef46: 214: Improve the message given when a change can be integrated
  • e895b3c: 172: Moving a PR from draft state should trigger a new check
  • c4a68c5: 213: More granular configuration for mailing list notifier
  • 0f32008: 212: Retry notifications for updaters that can check current state
  • d6aa3e1: 211: git-pr: add status subcommand
  • 6956b34: 207: Retry failed mlbridge comment post operations
  • b95c20f: 210: git-pr: add BRANCH column to git-pr list
  • 0a10693: 209: git-pr: add ISSUE column to git-pr list
  • e781a16: 179: Make git-pr flags configurable
  • 7cb0f72: 208: git-publish: off-by-one error when parsing --quiet
  • ba7d001: 206: Add proper escaping for replacement pattern
  • e6ed98e: 205: git-pr: allow configurable default action
  • e6d33cd: 204: git-sync: must fetch before --fast-forward
  • 6219735: 203: git-pr: add flag --jcheck to run jcheck as part of git-pr create
  • 98ce3f2: 202: git-pr create should use a proper Markdown file
  • 71aff94: 199: Set fixVersion in an issue when a commit is integrated
  • 70c8158: 201: git-info should by default show all options
  • f73b2cb: 200: git-info should show link to review
  • e3aefe9: 198: git-pr should remember mapping between PR and local branch

Your commit was automatically rebased without conflicts.

Pushed as commit 8552658.

@openjdk openjdk bot removed the ready label Jan 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 8552658
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-15 12:45:52 +0000
URL: https://git.openjdk.java.net/skara/commit/85526580

Add test mailserver logging

Reviewed-by: ehelin

! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants