Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #33

Closed
wants to merge 1 commit into from
Closed

Update README.md #33

wants to merge 1 commit into from

Conversation

@jddarcy
Copy link
Member

jddarcy commented Jul 31, 2019

Fix typo in description of hgbridge.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
Fix typo in description of hgbridge.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2019

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jul 31, 2019
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2019

Webrevs

@mlbridge
Copy link

mlbridge bot commented Jul 31, 2019

Mailing list message from Joe Darcy joe.darcy@oracle.com

PS No additional typos were found in the README.

-Joe

On 7/30/2019 10:48 PM, Joe Darcy via github.com wrote:

Fix typo in description of hgbridge.


Commits:

  • ebd737b: Update README.md
    Fix typo in description of hgbridge.

Pull request:
http://git.openjdk.java.net/skara/pull/33

Webrev:
https://openjdk.github.io/cr/skara/33/webrev.00

Patch:
http://git.openjdk.java.net/skara/pull/33.diff

Fetch command:
git fetch https://github.com/openjdk/skara.git pull/33/head:pull/33

@mlbridge
Copy link

mlbridge bot commented Jul 31, 2019

Mailing list message from Jonathan Gibbons jonathan.gibbons@oracle.com

Joe,

I don't know if I count as a Reviewer, but the change looks good to me.

-- Jon

On 07/31/2019 10:25 AM, Joe Darcy wrote:

PS No additional typos were found in the README.

-Joe

On 7/30/2019 10:48 PM, Joe Darcy via github.com wrote:

Fix typo in description of hgbridge.


Commits:
? - ebd737b:??? Update README.md
??????????? Fix typo in description of hgbridge.

Pull request:
http://git.openjdk.java.net/skara/pull/33

Webrev:
https://openjdk.github.io/cr/skara/33/webrev.00

Patch:
http://git.openjdk.java.net/skara/pull/33.diff

Fetch command:
git fetch https://github.com/openjdk/skara.git pull/33/head:pull/33

@edvbld
edvbld approved these changes Aug 5, 2019
Copy link
Member

edvbld left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Aug 5, 2019
@openjdk
Copy link

openjdk bot commented Aug 5, 2019

@jddarcy This change can now be integrated. The commit message will be:

Update README.md

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 83ad6c8: Get resource path from URI to avoid getting spurious leading path separator on Windows

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 5, 2019
@jddarcy
Copy link
Member Author

jddarcy commented Aug 5, 2019

/integrate

@openjdk openjdk bot closed this Aug 5, 2019
@openjdk
Copy link

openjdk bot commented Aug 5, 2019

@jddarcy The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 1c8b488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.