Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215: Verify webrev links before considering publication successful #345

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 8, 2020

Hi all,

Please review this change which ensures that webrev links can be successfully reached before returning from the publication step.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-215: Verify webrev links before considering publication successful

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 8, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 8, 2020

Webrevs

edvbld
edvbld approved these changes Jan 13, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just a small suggestion on narrowing the range of successful HTTP status codes 😉

.build();
try {
var response = client.send(request, HttpResponse.BodyHandlers.ofString());
if (response.statusCode() < 400) {
Copy link
Member

@edvbld edvbld Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (response.statusCode() < 400) {
if (respons.statusCode() >= 200 && response.statusCode() < 400) {

Copy link
Member Author

@rwestberg rwestberg Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think < 200's propagate outside of the http client implementation, so should be reasonably safe.

@openjdk openjdk bot removed the rfr label Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

215: Verify webrev links before considering publication successful

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 13, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 13, 2020

Thanks for reviewing!

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 13, 2020

/integrate

@openjdk openjdk bot closed this Jan 13, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@rwestberg
Pushed as commit 3c8b6bc.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 3c8b6bc
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-13 08:32:13 +0000
URL: https://git.openjdk.java.net/skara/commit/3c8b6bcb

215: Verify webrev links before considering publication successful

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/module-info.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java
+ test/src/main/java/org/openjdk/skara/test/TestWebrevServer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants