Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsafe features when importing #347

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 13, 2020

Hi all,

Please review this change that adds a new required flag for running git fast-import, required after the latest git security fixes.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 13, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@rwestberg rwestberg marked this pull request as ready for review Jan 13, 2020
@openjdk openjdk bot added the rfr label Jan 13, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2020

Webrevs

@edvbld
Copy link
Member

@edvbld edvbld commented Jan 13, 2020

What about older git versions that might not support the flag --allow-unsafe-features?

@edvbld
Copy link
Member

@edvbld edvbld commented Jan 13, 2020

/test

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

Could not create test job

@edvbld
Copy link
Member

@edvbld edvbld commented Jan 13, 2020

/test

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

Could not create test job

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 13, 2020

Don't really see any advantage in supporting versions containing multiple CVE's for the hgbridge I guess :)

@openjdk openjdk bot added the build label Jan 13, 2020
edvbld
edvbld approved these changes Jan 13, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Allow unsafe features when importing

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@edvbld
Copy link
Member

@edvbld edvbld commented Jan 13, 2020

Don't really see any advantage in supporting versions containing multiple CVE's for the hgbridge I guess :)

No, I agree.

Thanks,
Erik

@openjdk openjdk bot added the ready label Jan 13, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 13, 2020

/integrate

@openjdk openjdk bot closed this Jan 13, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 7d878e7: 222: Implement backport issue creation
  • af856f5: 216: git-pr: show response to test and integrate commands

Your commit was automatically rebased without conflicts.

Pushed as commit 9c67b6d.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 9c67b6d
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-13 15:17:14 +0000
URL: https://git.openjdk.java.net/skara/commit/9c67b6da

Allow unsafe features when importing

Reviewed-by: ehelin

! bots.dockerfile
! test.dockerfile
! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants