Allow unsafe features when importing

[rwestberg]

Hi all,

Please review this change that adds a new required flag for running git fast-import, required after the latest git security fixes.

Best regards,
Robin

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Erik Helin (ehelin - Reviewer)

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 01: Full (a270d59)
• 00: Full (4fa9a39)

[edvbld]

What about older git versions that might not support the flag --allow-unsafe-features?

[edvbld]

/test

[openjdk]

Could not create test job

[edvbld]

/test

[openjdk]

Could not create test job

[rwestberg]

Don't really see any advantage in supporting versions containing multiple CVE's for the hgbridge I guess :)

[edvbld]

Looks good!

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Allow unsafe features when importing

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

Don't really see any advantage in supporting versions containing multiple CVE's for the hgbridge I guess :)

No, I agree.

Thanks,
Erik

[rwestberg]

/integrate

[openjdk]

@rwestberg The following commits have been pushed to master since your change was applied:

• 7d878e7: 222: Implement backport issue creation
• af856f5: 216: git-pr: show response to test and integrate commands

Your commit was automatically rebased without conflicts.

Pushed as commit 9c67b6d.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: 9c67b6d
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-13 15:17:14 +0000
URL: https://git.openjdk.java.net/skara/commit/9c67b6da

Allow unsafe features when importing

Reviewed-by: ehelin

! bots.dockerfile
! test.dockerfile
! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java