Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate issue properties when creating backports #352

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 15, 2020

Hi all,

Please review this change that ensures that certain properties are propagated when creating backport issues.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2020

Webrevs

edvbld
edvbld approved these changes Jan 15, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Propagate issue properties when creating backports

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.
    ➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 15, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 15, 2020

/integrate

@openjdk openjdk bot closed this Jan 15, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2020

@rwestberg
Pushed as commit fd51409.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: fd51409
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-15 12:36:44 +0000
URL: https://git.openjdk.java.net/skara/commit/fd514098

Propagate issue properties when creating backports

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueProject.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java
! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java
! test/src/main/java/org/openjdk/skara/test/IssueData.java
! test/src/main/java/org/openjdk/skara/test/TestHost.java
! test/src/main/java/org/openjdk/skara/test/TestIssue.java
! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants