Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post the incremental webrev url in the PR comment #367

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 20, 2020

Hi all,

Please review this change that fixes a regression where the link to the incremental webrev wasn't posted in the PR status comment.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2020

Webrevs

edvbld
edvbld approved these changes Jan 20, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks!

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 20, 2020

/integrate

@openjdk openjdk bot removed the rfr label Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Post the incremental webrev url in the PR comment

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 20, 2020
@openjdk openjdk bot closed this Jan 20, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@rwestberg
Pushed as commit 9f56fca.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 9f56fca
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-20 14:23:34 +0000
URL: https://git.openjdk.java.net/skara/commit/9f56fcae

Post the incremental webrev url in the PR comment

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevNotification.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants