Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

220: webrev version unknown message #370

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 21, 2020

Hi all,

please review this patch that add proper versions to the automatically generated
webrevs. I also took the opportunity to add a --version flag to the bot
launcher.

Thanks,
Erik

Testing

  • Manual testing of skara-bots and the CLI tools

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-220: webrev version unknown message

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

Copy link
Member

@rwestberg rwestberg left a comment

Thanks, looks good!

@openjdk openjdk bot removed the rfr label Jan 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

220: webrev version unknown message

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 21, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 21, 2020

/integrate

@openjdk openjdk bot closed this Jan 21, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2020

@edvbld
Pushed as commit f4cc461.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 21, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants