Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

238: Add link to upstream repository to generated webrevs #373

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 22, 2020

Hi all,

please review this small patch that adds a link to the upstream repository in
automatically generated webrevs.

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-238: Add link to upstream repository to generated webrevs

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 22, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Jan 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

238: Add link to upstream repository to generated webrevs

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

Copy link
Member

@rwestberg rwestberg left a comment

Are you sure the URl does not contain sensitive information?

@openjdk openjdk bot added rfr and removed ready labels Jan 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2020

Mailing list message from Erik Helin on skara-dev:

On 1/22/20 5:54 PM, Robin Westberg wrote:

On Wed, 22 Jan 2020 16:47:17 GMT, Erik Helin <ehelin at openjdk.org> wrote:

Hi all,

please review this small patch that adds a link to the upstream repository in
automatically generated webrevs.

Thanks,
Erik

Are you sure the URl does not contain sensitive information?

Yes, I'm sure, the URL is to the upstream repository, not the personal fork.

Thanks,
Erik

Copy link
Member

@rwestberg rwestberg left a comment

Thanks!

@openjdk openjdk bot added ready and removed rfr labels Jan 22, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 22, 2020

/integrate

@openjdk openjdk bot closed this Jan 22, 2020
@openjdk openjdk bot added the integrated label Jan 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2020

@edvbld
Pushed as commit db6fbee.

@openjdk openjdk bot removed the ready label Jan 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: db6fbee
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-22 17:03:34 +0000
URL: https://git.openjdk.java.net/skara/commit/db6fbee3

238: Add link to upstream repository to generated webrevs

Reviewed-by: rwestberg

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants