Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

223: Make required re-reviewing configurable #376

Closed
wants to merge 5 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 23, 2020

Hi all,

Please review this change that makes it possible to configure (per project) if additional commits to a pull request renders previous reviews invalid or not. It also tweaks the behavior of the rfr label slightly - instead of dropping it when a PR is reviewed and receives the ready label, is will remain for as long the PR is eligible for further reviews. This should reduce the number of label transitions when this feature is enabled.

The change also contains a bit of refactoring to make it easier to add more project specific configuration in the future.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-223: Make required re-reviewing configurable

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 23, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 23, 2020

edvbld
edvbld approved these changes Jan 23, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 23, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

223: Make required re-reviewing configurable

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

# Conflicts:
#	bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
@openjdk openjdk bot removed the outdated label Jan 23, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 23, 2020

/integrate

@openjdk openjdk bot closed this Jan 23, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 23, 2020

@rwestberg
Pushed as commit 7a6119d.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 23, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 7a6119d
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-23 13:16:24 +0000
URL: https://git.openjdk.java.net/skara/commit/7a6119d1

223: Make required re-reviewing configurable

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/AllowCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java
+ bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotBuilder.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CommandTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/LabelerTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ReviewersTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/VetoTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants