223: Make required re-reviewing configurable

[rwestberg]

Hi all,

Please review this change that makes it possible to configure (per project) if additional commits to a pull request renders previous reviews invalid or not. It also tweaks the behavior of the rfr label slightly - instead of dropping it when a PR is reviewed and receives the ready label, is will remain for as long the PR is eligible for further reviews. This should reduce the number of label transitions when this feature is enabled.

The change also contains a bit of refactoring to make it easier to add more project specific configuration in the future.

Best regards,
Robin

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

SKARA-223: Make required re-reviewing configurable

Approvers

• Erik Helin (ehelin - Reviewer) Note! Review applies to 9f819ab

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 04: Full - Incremental (2f9a133)
• 03: Full - Incremental (ac9729f)
• 02: Full (3490d3a)
• 01: Full - Incremental (9f819ab)
• 00: Full (ef0825c)

[edvbld]

Looks good!

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

223: Make required re-reviewing configurable

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg
Pushed as commit 7a6119d.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: 7a6119d
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-23 13:16:24 +0000
URL: https://git.openjdk.java.net/skara/commit/7a6119d1

223: Make required re-reviewing configurable

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/AllowCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java
+ bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotBuilder.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CommandTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/LabelerTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ReviewersTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/VetoTests.java