Make it possible to only allow PRs against a select set of target branches

[rwestberg]

Hi all,

Please review this change that makes it possible to only allow PRs to target a select set of branches.

Best regards,
Robin

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Erik Helin (ehelin - Reviewer) Note! Review applies to 7b261d7

[bridgekeeper]

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 02: Full - Incremental (19779e4)
• 01: Full - Incremental (7b261d7)
• 00: Full (7c3c309)

[rwestberg]

How about enumerating the valid targets in the error message?

[edvbld]

Thanks, looks good! Just a small nit with regards to the method name 😉

[openjdk]

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Make it possible to only allow PRs against a select set of target branches

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[rwestberg]

/integrate

[openjdk]

@rwestberg The following commits have been pushed to master since your change was applied:

• d62e49e: 246: Avoid bridging too large emails
• 1b57804: 245: CLI tools do not consider git's http.proxy configuration
• b0a9758: 244: Legacy reviewers jcheck configuration does not reset default

Your commit was automatically rebased without conflicts.

Pushed as commit 10552fd.

[mlbridge]

Mailing list message from Robin Westberg on skara-dev:

Changeset: 10552fd
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-24 14:08:46 +0000
URL: https://git.openjdk.java.net/skara/commit/10552fd2

Make it possible to only allow PRs against a select set of target branches

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotBuilder.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java